Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Remove generator references from readme and index #734

Merged
merged 1 commit into from
Jul 30, 2015

Conversation

codydaig
Copy link
Member

Removed generator references from the README and index view.

@ilanbiala @lirantal - I would suggest this get merged into 0.4.0 prior to the release to prevent confusion.

@ilanbiala
Copy link
Member

@lirantal maybe we should even say that the generator is out-of-date and should not be used until further notice to prevent more issues?

@ilanbiala ilanbiala added this to the 0.4.0 milestone Jul 29, 2015
@lirantal
Copy link
Member

@ilanbiala no I wouldn't say "not be used' that's too harsh. I think we should do the same as in the docs which I recommended @codydaig earlier - let's just say that the generator uses the 0.3.0 version of meanjs

### Cloning The GitHub Repository
You can also use Git to directly clone the MEAN.JS repository:
The reccommended way to get MEAN.js is to use git to directly clone the MEAN.JS repository:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra c

@ilanbiala
Copy link
Member

@lirantal LGTM. Merge when you are ready.

@codydaig
Copy link
Member Author

@ilanbiala @lirantal I don't know if m latest change is showing up. Travis CI saw my changes but GitHub is still showing my old commit (for me at least)

@lirantal
Copy link
Member

@ilanbiala so you don't want to keep the yeoman generator section with saying that it's for the 0.3.0 version?

@codydaig
Copy link
Member Author

@lirantal #735 is what I interpreted from our previous discussion.

@lirantal
Copy link
Member

@codydaig so again, for now I vote for keeping the Yo Generator paragraph but having it say that it works with the 0.3.0 branch and not the current master/0.4.0 release, and I'll also switch that section with the Cloning The GitHub Repository section so the latter is showing up first.

WDYT?

@codydaig
Copy link
Member Author

@lirantal Is the latest view what you were thinking?

(I'll squash before we merge this in.)

@lirantal
Copy link
Member

yep.

@codydaig
Copy link
Member Author

Squashed.

@ilanbiala
Copy link
Member

@lirantal good to merge or did you want anything else changed?

ilanbiala added a commit that referenced this pull request Jul 30, 2015
Update generator references from readme and index
@ilanbiala ilanbiala merged commit b8b8d01 into meanjs:0.4.0 Jul 30, 2015
@ilanbiala ilanbiala assigned ilanbiala and unassigned lirantal Jul 30, 2015
@lirantal
Copy link
Member

yep, thanks for pushing that.

@codydaig codydaig deleted the docs/040release branch August 20, 2015 22:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants